feat: optimizing sending answers to questions by bdraco · Pull Request #1227 · python-zeroconf/python-zeroconf

Conversation

@bdraco

Avoids construction of the lambda on each response, uses attrgetter which is pre-built

@codecov

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1492e41) 99.82% compared to head (6ee17d8) 99.82%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1227   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          25       25           
  Lines        2790     2792    +2     
  Branches      479      479           
=======================================
+ Hits         2785     2787    +2     
  Misses          3        3           
  Partials        2        2           
Files Changed Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_handlers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review

August 22, 2023 14:45

@bdraco bdraco deleted the optimize_outgoing_answers branch

August 22, 2023 14:46

1 participant

@bdraco