feat: reduce overhead to process incoming updates by avoiding the handle_response shim by bdraco · Pull Request #1247 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
feat: reduce overhead to process incoming updates by avoiding the handle_response shim#1247
feat: reduce overhead to process incoming updates by avoiding the handle_response shim#1247
Conversation
Copy link Copy Markdown
Member
handle_response was left over from before async_updates_from_response was moved into the record manager. Call the record manager directly from the listener instead so we can use a cimport to avoid converting back to python objects
…dle_response shim handle_response was left over from before async_updates_from_response was moved into the record manager. Call the record manager directly from the listener instead
Copy link Copy Markdown
Codecov Report
Patch coverage is 100.00% of modified lines.
| Files Changed | Coverage |
|---|---|
| src/zeroconf/__init__.py | 100.00% |
| src/zeroconf/_core.py | 100.00% |
| src/zeroconf/_listener.py | 100.00% |
📢 Thoughts on this report? Let us know!.
bdraco
changed the title
feat: reduce overhead to process incoming updates by removing the handle_response shim
feat: reduce overhead to process incoming updates by avoiding the handle_response shim
bdraco added 3 commits
September 1, 2023 22:00
bdraco
marked this pull request as ready for review
bdraco
merged commit
5e31f0a
into
master
bdraco
deleted the
remove_shim
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant