feat: significantly speed up writing outgoing dns records by bdraco · Pull Request #1260 · python-zeroconf/python-zeroconf

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bdraco

Copy link Copy Markdown

Member

@bdraco bdraco commented

Sep 7, 2023

edited

Loading

This is ~46% speed up.

  • pack is much faster
  • add some missing cdefs

@codecov

Copy link Copy Markdown

codecov bot commented

Sep 7, 2023

edited

Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/zeroconf/__init__.py 100.00%
src/zeroconf/_protocol/outgoing.py 100.00%

📢 Thoughts on this report? Let us know!.

@bdraco bdraco changed the title feat: try pack feat: significantly speed up writing outgoing dns records

Sep 7, 2023

@bdraco bdraco marked this pull request as ready for review

September 7, 2023 19:55

@bdraco bdraco merged commit bf2f366 into master

Sep 7, 2023

@bdraco bdraco deleted the pack branch

September 7, 2023 19:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdraco