feat: speed up answering questions by bdraco · Pull Request #1265 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
feat: speed up answering questions#1265
feat: speed up answering questions#1265
Conversation
Copy link Copy Markdown
Member
bdraco
commented
Sep 11, 2023
bdraco
commented
- Adds cdefs for all ServiceInfo record generators
- Adds cdefs for all ServiceInfo record generators
Copy link Copy Markdown
Codecov Report
Patch coverage is 100.00% of modified lines.
| Files Changed | Coverage |
|---|---|
| src/zeroconf/__init__.py | 100.00% |
| src/zeroconf/_handlers/query_handler.py | 100.00% |
| src/zeroconf/_services/info.py | 100.00% |
📢 Thoughts on this report? Let us know!.
bdraco commented Sep 11, 2023
| version: IPVersion = IPVersion.All, | ||
| ) -> List[DNSAddress]: | ||
| """Return matching DNSAddress from ServiceInfo.""" | ||
| return self._dns_addresses(override_ttl, version) |
Copy link Copy Markdown
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have preferred not to add the _ functions but I don't want this to be a breaking change
bdraco
marked this pull request as ready for review
bdraco
merged commit
37bfaf2
into
master
bdraco
deleted the
cdef_service_info_records
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant