feat: speed up writing name compression for outgoing packets by bdraco · Pull Request #1312 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
feat: speed up writing name compression for outgoing packets#1312
feat: speed up writing name compression for outgoing packets#1312
Conversation
bdraco added 2 commits
November 13, 2023 11:24This is a ~13.5% speed up
Copy link Copy Markdown
Codecov Report
All modified and coverable lines are covered by tests ✅
| Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/__init__.py | 100.00% <100.00%> (ø) |
|
| src/zeroconf/_protocol/outgoing.py | 100.00% <100.00%> (ø) |
📢 Thoughts on this report? Let us know!
bdraco added 5 commits
November 13, 2023 11:45bdraco commented Nov 13, 2023
| log.warning("packets() made no progress adding records; returning") | ||
| break | ||
|
|
||
| self._reset_for_next_packet() |
Copy link Copy Markdown
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't reset if we don't have more to add
Copy link Copy Markdown
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That can be another PR though
bdraco
marked this pull request as ready for review
bdraco
merged commit
9caeabb
into
master
bdraco
deleted the
outgoing_name_compression
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant