feat: speed up outgoing packet writer by bdraco · Pull Request #1313 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
Conversation
Copy link Copy Markdown
Member
- refactor the loop to only call
_has_more_to_addonce per loop when its a query - add some more cython types
- cache common shorts
This is a ~22% speed up
refactor the loop to only call _has_more_to_add once per loop when its a query
Copy link Copy Markdown
Codecov Report
All modified and coverable lines are covered by tests ✅
| Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/__init__.py | 100.00% <100.00%> (ø) |
|
| src/zeroconf/_protocol/outgoing.py | 100.00% <100.00%> (ø) |
📢 Thoughts on this report? Let us know!
bdraco added 6 commits
November 13, 2023 12:34
bdraco
marked this pull request as ready for review
bdraco
merged commit
55cf4cc
into
master
bdraco
deleted the
refactor_packets
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant