Home Original page

feat: speed up unpacking TXT record data in ServiceInfo by bdraco · Pull Request #1318 · python-zeroconf/python-zeroconf

Conversation

@bdraco

This is ~43% speed up

before
Processing 100000 properties took 0.1892200000002049 seconds

after
Processing 100000 properties took 0.10781029199961267 seconds

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd28476) 99.77% compared to head (42af9a0) 99.77%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1318   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          29       29           
  Lines        3084     3087    +3     
  Branches      518      518           
=======================================
+ Hits         3077     3080    +3     
  Misses          5        5           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title feat: speed up unpacking TXT in ServiceInfo feat: speed up unpacking TXT record data in ServiceInfo

Dec 2, 2023

@bdraco bdraco marked this pull request as ready for review

December 2, 2023 23:15

@bdraco bdraco deleted the refactor__unpack_text_into_properties branch

December 2, 2023 23:16

1 participant

@bdraco