fix: performance regression with ServiceInfo IPv6Addresses by bdraco · Pull Request #1330 · python-zeroconf/python-zeroconf
Conversation
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
39c4005) 99.77% compared to head (62008c7) 99.77%.
Report is 2 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1330 +/- ## ======================================= Coverage 99.77% 99.77% ======================================= Files 29 30 +1 Lines 3106 3143 +37 Branches 522 524 +2 ======================================= + Hits 3099 3136 +37 Misses 5 5 Partials 2 2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
while we are at it, we should cache is_link_local
Verified this solves it.
Need to add more coverage
bdraco
marked this pull request as ready for review
I should have cached is_unspecified as well as we have 1000s of calls to that 😢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 participant