fix: ensure IPv6 scoped address construction uses the string cache by bdraco · Pull Request #1336 · python-zeroconf/python-zeroconf
Conversation
Instead of using the __str__ cache on the object it was calling __format__ which isn't optimized
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
9b595a1) 99.77% compared to head (6e92caa) 99.77%.
Report is 3 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1336 +/- ## ======================================= Coverage 99.77% 99.77% ======================================= Files 30 30 Lines 3164 3164 Branches 528 528 ======================================= Hits 3157 3157 Misses 5 5 Partials 2 2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
bdraco
marked this pull request as ready for review
bdraco
deleted the
fix_scoped_addreses_not_using_string_cache
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 participant