Home Original page

fix: scheduling race with the QueryScheduler by bdraco · Pull Request #1347 · python-zeroconf/python-zeroconf

@bdraco

We should always call reschedule instead of schedule in case one is already scheduled. The code assumed records are always delivered in order which would be nice, but does not reflect a real network

@bdraco

@bdraco

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b595a1) 99.77% compared to head (bd99f29) 99.78%.
Report is 13 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1347   +/-   ##
=======================================
  Coverage   99.77%   99.78%           
=======================================
  Files          30       30           
  Lines        3164     3232   +68     
  Branches      528      536    +8     
=======================================
+ Hits         3157     3225   +68     
  Misses          5        5           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title fix: ensure correct scheduled query is removed from the heap fix: scheduling race with the QueryScheduler

Dec 16, 2023

@bdraco