feat: migrate to native types by Rotzbua · Pull Request #1472 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
bdraco merged 5 commits intopython-zeroconf:masterfrom
Jan 16, 2025Merged
feat: migrate to native types#1472
bdraco merged 5 commits intopython-zeroconf:masterfrom
feat: migrate to native types#1472
bdraco merged 5 commits intopython-zeroconf:masterfrom
Conversation
Copy link Copy Markdown
Contributor
As defined in PEP 585 – Type Hinting Generics In Standard Collections
Restriction
Do not migrate folder src due issues with cython
Reference
Rotzbua
marked this pull request as draft
Rotzbua
force-pushed
the
feat_migrate_native_types
branch
from
2de2f73 to
3d24643
Compare
Copy link Copy Markdown
CodSpeed Performance Report
Merging #1472 will not alter performance
Comparing Rotzbua:feat_migrate_native_types (fb7b555) with master (d20d8c1)
Summary
✅ 4 untouched benchmarks
Rotzbua
marked this pull request as ready for review
As defined in PEP 585 – Type Hinting Generics In Standard Collections https://peps.python.org/pep-0585/
Rotzbua
force-pushed
the
feat_migrate_native_types
branch
from
3d24643 to
e55f7d1
Compare
bdraco approved these changes Jan 16, 2025
Copy link Copy Markdown
Member
bdraco
left a comment
bdraco
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rotzbua
Copy link Copy Markdown
Member
bdraco
commented
Jan 16, 2025
bdraco commented
Jan 16, 2025@Rotzbua Would you please resolve conflicts when you get a chance
Copy link Copy Markdown
Member
bdraco
commented
Jan 16, 2025
bdraco commented
Jan 16, 2025nevermind, it was a simple conflict
bdraco reviewed Jan 16, 2025
tests/__init__.py
Outdated
Show resolved
Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
bdraco reviewed Jan 16, 2025
tests/__init__.py
Outdated
Show resolved
Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
bdraco
merged commit
22a0fb4
into
python-zeroconf:master
Rotzbua
deleted the
feat_migrate_native_types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants