fixed crash due to a decref of a borrowed reference in params array handling by lostmsu · Pull Request #1163

fixed crash due to a decref of a borrowed reference in params array handling by lostmsu · Pull Request #1163 · pythonnet/pythonnet

Conversation

What does this implement/fix? Explain your changes.

item is a return value of PyTuple_GetItem which returns borrowed reference.

Hence it should not have been decref'ed

Codecov Report

Merging #1163 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files           1        1           
  Lines         297      297           
=======================================
  Hits          257      257           
  Misses         40       40

Flag	Coverage Δ
#setup_linux	`64.98% <ø> (ø)`
#setup_windows	`72.05% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742463e...d87d033. Read the comment docs.

filmor pushed a commit that referenced this pull request

Jun 18, 2020

…ms array handling (#1163)

AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request

Jun 29, 2020