Re-enable the domain reload tests by BadSingleton · Pull Request #1404 · pythonnet/pythonnet
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 773
Merged
lostmsu merged 7 commits intopythonnet:masterfrom
May 3, 2021Merged
Re-enable the domain reload tests#1404
lostmsu merged 7 commits intopythonnet:masterfrom
Re-enable the domain reload tests#1404
lostmsu merged 7 commits intopythonnet:masterfrom
Conversation
Copy link
Contributor
BadSingleton
changed the title
Make the domain reload tests run again
Re-enable the domain reload tests
Add `src/domain_tests` to `testpaths` in pyproject.toml
BadSingleton
force-pushed
the
fix-1403
branch
from
a2877ef to
8f443f0
Compare
Copy link
Member
filmor
commented
Mar 1, 2021
filmor commented
Mar 1, 2021Sorry about that. Could you please add these as separate actions, though, instead of adding them to the normal testing? They are only relevant on Mono and .NET Framework anyhow.
Copy link
Contributor Author
BadSingleton
commented
Mar 4, 2021
BadSingleton commented
Mar 4, 2021I think adding them as a separate action is not optimal, as devs will have to run pytest specifying explicitly the domain tests. I added pytest filtering instead
BadSingleton added 3 commits
April 29, 2021 13:26
Copy link
Contributor Author
BadSingleton
commented
Apr 29, 2021
BadSingleton commented
Apr 29, 2021I think the timeouts are false positive. The domain tests takes about 1:15m to execute.
lostmsu
merged commit
33d771c
into
pythonnet:master
BadSingleton
deleted the
fix-1403
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants