Disallow runtime shutdown when the Python error indicator is set by lostmsu · Pull Request #1780 · pythonnet/pythonnet
Conversation
What does this implement/fix? Explain your changes.
Shutting down runtime when the Python error indicator is set has unpredictable behavior.
Checklist
- Updated the
CHANGELOG
@filmor that would be silent information loss.
This way will probably lead to a lot more unwanted behaviour in that a program that ends with Shutdown will not have its resources closed if an error is still set (as it will just crash on this exception), or am I misunderstanding something?
@filmor if they are at this point, they already have an unhandled exception. Generally speaking it is better to crash, than to try to close resources as you might persist a corrupted state and not get notified about it at all.
lostmsu
deleted the
disallow-shutdown-with-error-set
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters