Remove suggestions to use `internal` functions by filmor · Pull Request #2092 · pythonnet/pythonnet
Fixes #2091.
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
- Make sure to include one or more tests for your change
- If an enhancement PR, please create docs and at best an example
- Ensure you have signed the .NET Foundation CLA
- Add yourself to
AUTHORS - Updated the
CHANGELOG
Comment on lines -50 to -52
| When finished using Python APIs, managed code must call a corresponding | ||
| ``PythonEngine.ReleaseLock`` to release the GIL and allow other threads | ||
| to use Python. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, "when finished" section needs corresponding replacement (maybe merged with the acquisition part).
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see this being confusing a bit in regards with "disposing the return value" - as in "previously returned value" vs "call Py.GIL().Dispose() to release, but probably everyone would read it correctly.
filmor
deleted the
drop-internal-methods-from-docs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters