Linting and Formatting by filmor · Pull Request #2353 · pythonnet/pythonnet

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@filmor

Copy link

Member

@filmor filmor commented

Mar 31, 2024

  • Add formatting and linting for C# files
  • Format and fix lints in Python (test) code

@filmor

Copy link

Member Author

filmor commented

Mar 31, 2024

I must have messed something up in the C# code while trying to fix the NonCopyableAnalyzer reports. To be honest, at this point I'm not sure how much this one actually helps, seeing that patterns like return NewReference(...) are wrongly reported.

@lostmsu

Copy link

Member

lostmsu commented

Apr 7, 2024

Just doublechecking for C#: this change does the proper thing in regards to our .editorconfig? E.g. all settings default except the one set there?

@lostmsu

Copy link

Member

lostmsu commented

Apr 7, 2024

TBH, I am not sure formatting is important unless it is in some way extreme.

heartacker reacted with confused emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@filmor @lostmsu