Fixes #284.

This PR contains 3 componenents:

1. Remove all of the Py<2.5 workarounds that wrap exceptions in old-style class instances
2. Fix Trying to pickle an exception crashes the interpreter #284 by moving the exception args into the corresponding slot in the BaseException object instead of faking the functionality by overloading __getattr__
3. Remove the __getattr__ overload altogether since the only functionality it provides (lookup of .message) is deprecated in Python >= 2.6

The "args" slot of BaseException was not filled, instead we provided the
args through our __getattr__ implementation. This fails in BaseException_reduce
which depends on "args" being not NULL.

We fix this by explicitly setting the "args" slot on all CLR exception objects
on creation. This also makes tp_repr obsolete.

@filmor can you add tests compatible with both python 2 and 3 that use cPickle:

try:
   import cPickle as pickle
except:
   import pickle

@denfromufa Done. Please check :)

I haven't run the embedded tests, I'll check how to do that.

This is definitely a bug fix, and a pretty critical one from my point of view (as said, this was killing my worker processes in production).

Ok, please let me know if you have any luck running embedding tests and
then we can merge this for v2.2.0.

BTW, why do you pickle exceptions - really seems a wild idea to me?

On Wed, Nov 9, 2016 at 9:20 AM, Benedikt Reinartz notifications@github.com
wrote:

I haven't run the embedded tests, I'll check how to do that.

This is definitely a bug fix, and a pretty critical one from my point of
view (as said, this was killing my worker processes in production).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#286 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHgZ5eVtKokXm3Jlt06_TqaF3qQ8Ei7xks5q8eS6gaJpZM4KsPc9
.

The tests work against Python 3.5 (though they have various issues, I'll prepare a PR).

I pass the exceptions back from a multiprocessing worker to show them to the user, and during that they are automatically pickled.