String directives cleanup on Runtime by vmuriart · Pull Request #339 · pythonnet/pythonnet
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 773
Merged
vmuriart merged 5 commits intopythonnet:masterfrom
Jan 30, 2017Merged
String directives cleanup on Runtime#339
vmuriart merged 5 commits intopythonnet:masterfrom
String directives cleanup on Runtime#339
vmuriart merged 5 commits intopythonnet:masterfrom
Conversation
Copy link
Contributor
vmuriart
commented
Jan 29, 2017
vmuriart
commented
What does this implement/fix? Explain your changes.
- Refactors the UCS4/UC2 PY2/PY3 logic and clarifies when each section is applicable.
- Completed clean-up of unneeded PYTHON2x PYTHON3x definitions
Any other comments?
Python37 can be added to travis after merging both #329 and #335.
This would allow travis to test geninterop and we can monitor python37 if it introduces any breaking changes.
vmuriart added 5 commits
January 29, 2017 13:53That entire section is only for PY32 compatiblity
Clearly shows what each section does
Added Python37 definition, won't add interop until final release
vmuriart
self-assigned this
vmuriart
requested review from
den-run-ai,
filmor and
tonyroberts
tonyroberts approved these changes Jan 30, 2017
vmuriart
closed this
vmuriart
reopened this
vmuriart
merged commit
8a3009b
into
pythonnet:master
vmuriart
deleted the
directives
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants