Fix Console config, Add pyproj, Add PY3 to configurationmanager by vmuriart · Pull Request #346 · pythonnet/pythonnet
What does this implement/fix? Explain your changes.
Standardizes build configurations across the projects (Console.csproj had its own thing going on)
Adds @denfromufa 's *.pyproj with corrected configurations
vmuriart
changed the title
Fix MissingMinimumRules, Add pyproj
Fix Console config, Add pyproj
vmuriart
changed the title
Fix Console config, Add pyproj
Fix Console config, Add pyproj, Add PY3 to configurationmanager
| - export PYTHONPATH=`pwd`:$PYTHONPATH | ||
| - python src/tests/runtests.py | ||
| # - nunit-console src/embed_tests/bin/x64/ReleaseMono/Python.EmbeddingTest.dll | ||
| # - nunit-console src/embed_tests/bin/Python.EmbeddingTest.dll |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this still commented out?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It runs the tests but all say Cant find python.runtime error. Didn't have a chance to debug it. I'm keeping the tests paths updated though
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, fine by me then, but I'll open an issue for this, we should really start running those tests.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On appveyor, when we run them on py3 they freeze and hang the testrunner until the build bot times out (30 minutes or so?).
I stress tested it on PY27 and its def fixed there. Ran 10 times no issues.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filmor if we downgrade back to nunit 2.6.2 we can start running the tests. They will still fail, but nunit will gracefully fail and give us the error instead of whatever nunit3 is doing now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters