Catching exceptions from iterator MoveNext(), additional testing (issue #475, original pull request #523) by ArvidJB · Pull Request #693 · pythonnet/pythonnet
Conversation
What does this implement/fix? Explain your changes.
This request contains the changes from #523 and adds some additional testing as requested in the comments on that request
Does this close any currently open issues?
Issue #475
Any other comments?
...
Checklist
Check all those that are applicable and complete.
Rickard Holmberg and others added 6 commits
June 25, 2018 16:28Codecov Report
Merging #693 into master will increase coverage by
0.02%.
The diff coverage is100%.
@@ Coverage Diff @@ ## master #693 +/- ## ========================================== + Coverage 76.9% 76.93% +0.02% ========================================== Files 63 63 Lines 5582 5589 +7 Branches 890 891 +1 ========================================== + Hits 4293 4300 +7 Misses 998 998 Partials 291 291
| Flag | Coverage Δ | |
|---|---|---|
| #setup_linux | 69.42% <ø> (ø) |
⬆️ |
| #setup_windows | 76.11% <100%> (+0.02%) |
⬆️ |
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/runtime/iterator.cs | 88.88% <100%> (+7.07%) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 545c549...2131292. Read the comment docs.
@rickardraysearch @ArvidJB Thank you very much for your contribution and sorry (especially to @rickardraysearch) for the long time until it was finally merged.
Just to clarify, the question I had was a pure lack-of-understanding question, I'm fine if this behaviour (i.e. always traverse exactly one level into the exception chain) if it's consistent with the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters