Catching exceptions from iterator MoveNext(), additional testing (issue #475, original pull request #523) by ArvidJB · Pull Request #693 · pythonnet/pythonnet

Conversation

@ArvidJB

What does this implement/fix? Explain your changes.

This request contains the changes from #523 and adds some additional testing as requested in the comments on that request

Does this close any currently open issues?

Issue #475

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

Rickard Holmberg and others added 6 commits

June 25, 2018 16:28
(cherry picked from commit 31a4482)
(cherry picked from commit 8531755)
(cherry picked from commit 9e08150)
(cherry picked from commit 4956b3e)
(cherry picked from commit 470773f)

@codecov

Codecov Report

Merging #693 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage    76.9%   76.93%   +0.02%     
==========================================
  Files          63       63              
  Lines        5582     5589       +7     
  Branches      890      891       +1     
==========================================
+ Hits         4293     4300       +7     
  Misses        998      998              
  Partials      291      291
Flag Coverage Δ
#setup_linux 69.42% <ø> (ø) ⬆️
#setup_windows 76.11% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/runtime/iterator.cs 88.88% <100%> (+7.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545c549...2131292. Read the comment docs.

@filmor

@rickardraysearch @ArvidJB Thank you very much for your contribution and sorry (especially to @rickardraysearch) for the long time until it was finally merged.

Just to clarify, the question I had was a pure lack-of-understanding question, I'm fine if this behaviour (i.e. always traverse exactly one level into the exception chain) if it's consistent with the rest.