feat: Add converter support for logical_and by mfeliz-cruise · Pull Request #1856 · pytorch/TensorRT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mfeliz-cruise

Copy link

Contributor

Description

Adds converter support for aten::logical_and
https://pytorch.org/docs/stable/generated/torch.logical_and.html

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion

Issues re: Conversion stage

component: converters

Issues re: Specific op converters

component: core

Issues re: The core compiler

component: tests

Issues re: Tests

labels

Apr 24, 2023

@mfeliz-cruise mfeliz-cruise changed the title Add converter support for logical_and feat: Add converter support for logical_and

Apr 24, 2023

@github-actions github-actions bot requested a review from narendasan

April 24, 2023 23:58
Copy link

Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the tests test both cases where we expect true and false here?

@mfeliz-cruise

Copy link

Contributor Author

Do the tests test both cases where we expect true and false here?

Yes, both paths are exercised.

@narendasan narendasan merged commit c5cc6e3 into pytorch:main

Apr 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan Awaiting requested review from narendasan

Assignees

No one assigned

Labels

cla signed component: conversion

Issues re: Conversion stage

component: converters

Issues re: Specific op converters

component: core

Issues re: The core compiler

component: tests

Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfeliz-cruise @narendasan @facebook-github-bot