feat: Add converter support for logical_and by mfeliz-cruise · Pull Request #1856 · pytorch/TensorRT
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 384
Merged
narendasan merged 1 commit intopytorch:mainfrom
Apr 28, 2023Merged
feat: Add converter support for logical_and#1856
narendasan merged 1 commit intopytorch:mainfrom
feat: Add converter support for logical_and#1856
narendasan merged 1 commit intopytorch:mainfrom
Conversation
Copy link
Contributor
mfeliz-cruise
commented
Apr 24, 2023
mfeliz-cruise
commented
Description
Adds converter support for aten::logical_and
https://pytorch.org/docs/stable/generated/torch.logical_and.html
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
- New feature (non-breaking change which adds functionality)
Checklist:
- My code follows the style guidelines of this project (You can use the linters)
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas and hacks
- I have made corresponding changes to the documentation
- I have added tests to verify my fix or my feature
- New and existing unit tests pass locally with my changes
- I have added the relevant labels to my PR in so that relevant reviewers are notified
facebook-github-bot
added
the
cla signed
label
github-actions
bot
added
component: conversion
labels
Apr 24, 2023
mfeliz-cruise
changed the title
Add converter support for logical_and
feat: Add converter support for logical_and
github-actions
bot
requested a review
from narendasan
narendasan reviewed Apr 27, 2023
Copy link
Collaborator
narendasan
left a comment
narendasan
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the tests test both cases where we expect true and false here?
Copy link
Contributor Author
mfeliz-cruise
commented
Apr 28, 2023
mfeliz-cruise commented
Apr 28, 2023Do the tests test both cases where we expect true and false here?
Yes, both paths are exercised.
mfeliz-cruise
requested a review
from narendasan
narendasan
merged commit
c5cc6e3
into
pytorch:main
bowang007 pushed a commit that referenced this pull request
Apr 29, 2023This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment