feat: Add converter for aten::log2 by mfeliz-cruise · Pull Request #1866 · pytorch/TensorRT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mfeliz-cruise

Copy link

Contributor

Description

Adds converter support for aten::log2. Uses the same method as onnx: https://github.com/pytorch/pytorch/blob/main/torch/onnx/symbolic_opset9.py#L5279

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion

Issues re: Conversion stage

component: converters

Issues re: Specific op converters

component: core

Issues re: The core compiler

component: tests

Issues re: Tests

labels

Apr 27, 2023

@github-actions github-actions bot requested a review from narendasan

April 27, 2023 21:46
Copy link

Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 1c9b2a1 into pytorch:main

Apr 27, 2023

bowang007 pushed a commit that referenced this pull request

Apr 29, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

No one assigned

Labels

cla signed component: conversion

Issues re: Conversion stage

component: converters

Issues re: Specific op converters

component: core

Issues re: The core compiler

component: tests

Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfeliz-cruise @narendasan @facebook-github-bot