fix: Add torchvision legacy CI parameter by gs-olive · Pull Request #1918 · pytorch/TensorRT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@gs-olive

Copy link

Contributor

Description

  • Addresses nightly legacy CI failure

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
    • CI Testing
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this

May 13, 2023

@gs-olive gs-olive force-pushed the torchvision_legacy branch 11 times, most recently from b35d7ea to 4ed00ca Compare

May 13, 2023 21:57

@gs-olive gs-olive force-pushed the torchvision_legacy branch from 4ed00ca to ddd2f01 Compare

May 13, 2023 23:06

@gs-olive gs-olive changed the title minor fix: Add torchvision legacy CI parameter fix: Add torchvision legacy CI parameter

May 15, 2023
Copy link

Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gs-olive reacted with thumbs up emoji

@gs-olive gs-olive merged commit d4e5ed0 into pytorch:main

May 15, 2023

@gs-olive gs-olive deleted the torchvision_legacy branch

May 15, 2023 19:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gs-olive @narendasan @facebook-github-bot