feat: Add support for passing through build issues in Dynamo compile by gs-olive · Pull Request #1952 · pytorch/TensorRT

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@gs-olive

Description

  • Add support for pass_through_build_failures keyword arg
  • Restructure testing utilities
  • Add minor typo fixes

Fixes #1927

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive marked this pull request as ready for review

May 25, 2023 04:43

@gs-olive gs-olive added the WIP

Work is in progress, pull request should not be merged yet

label

May 25, 2023

@gs-olive gs-olive removed the WIP

Work is in progress, pull request should not be merged yet

label

May 25, 2023

@gs-olive gs-olive added the WIP

Work is in progress, pull request should not be merged yet

label

May 25, 2023

@gs-olive gs-olive removed the WIP

Work is in progress, pull request should not be merged yet

label

May 25, 2023
- Add support for `pass_through_build_failures` keyword arg
- Add minor typo fixes

narendasan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gs-olive added a commit that referenced this pull request

May 26, 2023

narendasan pushed a commit that referenced this pull request

May 30, 2023

Labels