feat: support chunk dynamo converter by zewenli98 · Pull Request #2401 · pytorch/TensorRT
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 383
Merged
zewenli98 merged 4 commits intopytorch:mainfrom
Oct 25, 2023Merged
feat: support chunk dynamo converter#2401
zewenli98 merged 4 commits intopytorch:mainfrom
feat: support chunk dynamo converter#2401
zewenli98 merged 4 commits intopytorch:mainfrom
Conversation
Copy link
Collaborator
Description
Support chunk dynamo converter. This is a part of slice converter.
Fixes part of #2215
Type of change
- New feature (non-breaking change which adds functionality)
Checklist:
- My code follows the style guidelines of this project (You can use the linters)
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas and hacks
- I have made corresponding changes to the documentation
- I have added tests to verify my fix or my feature
- New and existing unit tests pass locally with my changes
- I have added the relevant labels to my PR in so that relevant reviewers are notified
facebook-github-bot
added
the
cla signed
label
github-actions
bot
added
component: api [Python]
labels
Oct 17, 2023
github-actions
bot
requested a review
from peri044
zewenli98
self-assigned this
zewenli98
requested a review
from gs-olive
gs-olive reviewed Oct 18, 2023
Copy link
Contributor
gs-olive
left a comment
gs-olive
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor style comment. Otherwise looks good!
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py
Outdated
Show resolved
Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py Outdated Show resolved Hide resolved
gs-olive approved these changes Oct 18, 2023
Copy link
Contributor
gs-olive
left a comment
gs-olive
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, pending the minor change requested + CI!
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py
Outdated
Show resolved
Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py Outdated Show resolved Hide resolved
zewenli98
merged commit
533215c
into
pytorch:main
zewenli98
deleted the
chunk_dynamo_converter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants