feat: support cumsum dynamo converter by zewenli98 · Pull Request #2403 · pytorch/TensorRT

@zewenli98

Description

Support cumsum dynamo converter. This is a part of slice converter.

Fixes part of #2215

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

gs-olive

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments, otherwise looks good!

@zewenli98

Thanks for the comments! They have been fixed!

gs-olive

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please rebase once #2418 is merged, and then ensure this PR also passes all of CI.

@zewenli98

@zewenli98

@zewenli98

Got errors:

FAILED models/test_export_serde.py::test_base_full_compile - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_base_full_compile_multiple_outputs - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_base_full_compile_save_load - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_hybrid_relu_fallback - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_resnet18_save_load - KeyError: 'parameter name can\'t contain "."'

Can we merge it now? or waiting for a fix to this bug?

@gs-olive

I think it can be merged while that fix is in progress, since it passes all of the newly added tests in CI and none of those models would invoke this specific converter.

gs-olive pushed a commit that referenced this pull request

Dec 5, 2023

gs-olive pushed a commit that referenced this pull request

Dec 5, 2023