Add support for `aten.pixel_unshuffle` dynamo converter by HolyWu · Pull Request #2696 · pytorch/TensorRT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

narendasan merged 1 commit intopytorch:mainfrom

HolyWu:pixel_unshuffle

Apr 5, 2024

Merged

Add support for aten.pixel_unshuffle dynamo converter#2696

narendasan merged 1 commit intopytorch:mainfrom

HolyWu:pixel_unshuffle

Conversation

@HolyWu

Copy link

Contributor

@HolyWu HolyWu commented

Mar 17, 2024

Description

Fixes #2694

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests

Issues re: Tests

component: conversion

Issues re: Conversion stage

component: converters

Issues re: Specific op converters

component: api [Python]

Issues re: Python API

component: dynamo

Issues relating to the `torch.compile` or `torch._dynamo.export` paths

labels

Mar 17, 2024

@github-actions github-actions bot requested a review from narendasan

March 17, 2024 09:55

@gs-olive gs-olive requested a review from zewenli98

March 18, 2024 17:12
Copy link

Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending on CI.

@HolyWu HolyWu requested a review from zewenli98

March 23, 2024 05:42

@narendasan narendasan merged commit 7d30714 into pytorch:main

Apr 5, 2024

@HolyWu HolyWu deleted the pixel_unshuffle branch

April 6, 2024 04:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan Awaiting requested review from narendasan

@zewenli98 zewenli98 Awaiting requested review from zewenli98

Assignees

No one assigned

Labels

cla signed component: api [Python]

Issues re: Python API

component: conversion

Issues re: Conversion stage

component: converters

Issues re: Specific op converters

component: dynamo

Issues relating to the `torch.compile` or `torch._dynamo.export` paths

component: tests

Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

↔ [Converter] Add support for torch.ops.aten.pixel_unshuffle.default in Torch-TensorRT

4 participants

@HolyWu @zewenli98 @narendasan @facebook-github-bot