fix: Missing parameters in compiler settings by gs-olive · Pull Request #2749 · pytorch/TensorRT
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 383
Merged
gs-olive merged 1 commit intopytorch:mainfrom
Apr 12, 2024Merged
fix: Missing parameters in compiler settings#2749
gs-olive merged 1 commit intopytorch:mainfrom
fix: Missing parameters in compiler settings#2749
gs-olive merged 1 commit intopytorch:mainfrom
Conversation
Copy link
Contributor
gs-olive
commented
Apr 12, 2024
gs-olive
commented
Description
- DLA parameters were not being propagated through the compiler specification in the TorchScript path
Fixes #2731
Type of change
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- [ x ] My code follows the style guidelines of this project (You can use the linters)
- [ x ] I have performed a self-review of my own code
- [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ x ] I have made corresponding changes to the documentation
- [ - ] I have added tests to verify my fix or my feature
- [ x ] New and existing unit tests pass locally with my changes
- [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified
gs-olive
requested a review
from narendasan
gs-olive
self-assigned this
facebook-github-bot
added
the
cla signed
label
github-actions
bot
requested a review
from peri044
peri044 approved these changes Apr 12, 2024
Copy link
Collaborator
peri044
left a comment
peri044
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gs-olive
merged commit
b76024d
into
pytorch:main
gs-olive
deleted the
dram_parameter_propagation
branch
gs-olive
mentioned this pull request
laikhtewari pushed a commit that referenced this pull request
May 24, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment