feat: support aten.log1p converter by chohk88 · Pull Request #2823 · pytorch/TensorRT
Description
A converter for the torch.ops.aten.log1p operation (elementwise log(1 + x))
Fixes # (issue)
Type of change
- New feature (non-breaking change which adds functionality)
Checklist:
- My code follows the style guidelines of this project (You can use the linters)
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas and hacks
- I have made corresponding changes to the documentation
- I have added tests to verify my fix or my feature
- New and existing unit tests pass locally with my changes
- I have added the relevant labels to my PR in so that relevant reviewers are notified
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment. The others LGTM. Can you merge it after fixing the functions' names?
|
|
||
|
|
||
| @dynamo_tensorrt_converter(torch.ops.aten.log2.default) | ||
| def log2( |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed the naming was inconsistent. Can you modify the function name to aten_ops_log2?
|
|
||
|
|
||
| @dynamo_tensorrt_converter(torch.ops.aten.log10.default) | ||
| def log10( |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. log10 -> aten_ops_log10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters