feat: Add support for multi-device safe mode in C++ by gs-olive · Pull Request #2824 · pytorch/TensorRT
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 383
Merged
gs-olive merged 1 commit intopytorch:mainfrom
May 21, 2024Merged
feat: Add support for multi-device safe mode in C++#2824
gs-olive merged 1 commit intopytorch:mainfrom
feat: Add support for multi-device safe mode in C++#2824
gs-olive merged 1 commit intopytorch:mainfrom
Conversation
Copy link
Contributor
gs-olive
commented
May 9, 2024
gs-olive
commented
Description
- Adds mirror functions and testing in C++ to control the
MULTI_DEVICE_SAFE_MODEflag
Fixes #2813
Type of change
Please delete options that are not relevant and/or add your own.
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- [ x ] My code follows the style guidelines of this project (You can use the linters)
- [ x ] I have performed a self-review of my own code
- [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ x ] I have made corresponding changes to the documentation
- [ x ] I have added tests to verify my fix or my feature
- [ x ] New and existing unit tests pass locally with my changes
- [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified
gs-olive
self-assigned this
facebook-github-bot
added
the
cla signed
label
gs-olive
changed the title
feat: Add support for multi-device safe mode modification in cpp
feat: Add support for multi-device safe mode in C++
github-actions
bot
added
component: tests
component: runtime labels
May 9, 2024
github-actions
bot
requested a review
from narendasan
narendasan approved these changes May 14, 2024
Copy link
Collaborator
narendasan
left a comment
narendasan
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gs-olive
merged commit
1e1c7a8
into
pytorch:main
gs-olive
deleted the
multi_device_safe_mode_cpp
branch
laikhtewari pushed a commit that referenced this pull request
May 24, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment