feat: Add support for multi-device safe mode in C++ by gs-olive · Pull Request #2824 · pytorch/TensorRT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@gs-olive

Copy link

Contributor

@gs-olive gs-olive commented

May 9, 2024

Description

  • Adds mirror functions and testing in C++ to control the MULTI_DEVICE_SAFE_MODE flag

Fixes #2813

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this

May 9, 2024

@gs-olive gs-olive changed the title feat: Add support for multi-device safe mode modification in cpp feat: Add support for multi-device safe mode in C++

May 9, 2024

@github-actions github-actions bot added component: tests

Issues re: Tests

component: core

Issues re: The core compiler

component: runtime labels

May 9, 2024

@github-actions github-actions bot requested a review from narendasan

May 9, 2024 16:02
Copy link

Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gs-olive reacted with thumbs up emoji

@gs-olive gs-olive merged commit 1e1c7a8 into pytorch:main

May 21, 2024

@gs-olive gs-olive deleted the multi_device_safe_mode_cpp branch

May 21, 2024 17:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels

Projects

None yet

Milestone

No milestone

3 participants

@gs-olive @narendasan @facebook-github-bot