feat: Cherry pick of Add validators for dynamic shapes in converter registration by peri044 · Pull Request #2849 · pytorch/TensorRT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@peri044

Copy link

Collaborator

@peri044 peri044 commented

May 17, 2024

Description

Cherry pick of #2796

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests

Issues re: Tests

component: conversion

Issues re: Conversion stage

component: api [Python]

Issues re: Python API

component: dynamo

Issues relating to the `torch.compile` or `torch._dynamo.export` paths

labels

May 17, 2024

@github-actions github-actions bot requested a review from gs-olive

May 17, 2024 17:21
Copy link

Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 mentioned this pull request

May 24, 2024

7 tasks

@peri044 peri044 merged commit 1e272b4 into main

May 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan approved these changes

@gs-olive gs-olive Awaiting requested review from gs-olive

Assignees

No one assigned

Labels

cla signed component: api [Python]

Issues re: Python API

component: conversion

Issues re: Conversion stage

component: dynamo

Issues relating to the `torch.compile` or `torch._dynamo.export` paths

component: tests

Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peri044 @narendasan @facebook-github-bot