feat: Implement FP32 accumulation for matmul by peri044 · Pull Request #3110 · pytorch/TensorRT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

peri044 merged 81 commits intomainfrom

fp32_acc

Oct 11, 2024

Conversation

@peri044

Copy link

Collaborator

@peri044 peri044 commented

Aug 21, 2024

Description

Implement FP32 accumulation for matmul layers

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

peri044 added 30 commits

June 12, 2024 17:24

@github-actions github-actions bot added component: core

Issues re: The core compiler

component: build system

Issues re: Build system

labels

Aug 30, 2024

@peri044 peri044 changed the base branch from llm_examples_main to main

September 3, 2024 15:02

@github-actions github-actions bot removed component: tests

Issues re: Tests

component: core

Issues re: The core compiler

component: build system

Issues re: Build system

labels

Sep 24, 2024

@peri044 peri044 mentioned this pull request

Sep 30, 2024

7 tasks

@github-actions github-actions bot added documentation

Improvements or additions to documentation

component: tests

Issues re: Tests

component: torch_compile labels

Sep 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan left review comments

@keehyuna keehyuna keehyuna left review comments

@github-actions github-actions[bot] github-actions[bot] requested changes

+1 more reviewer

@HolyWu HolyWu HolyWu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed component: api [Python]

Issues re: Python API

component: conversion

Issues re: Conversion stage

component: converters

Issues re: Specific op converters

component: dynamo

Issues relating to the `torch.compile` or `torch._dynamo.export` paths

component: lowering

Issues re: The lowering / preprocessing passes

component: tests

Issues re: Tests

component: torch_compile documentation

Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@peri044 @narendasan @HolyWu @keehyuna @facebook-github-bot @chohk88 @zewenli98