chore: flip use_cxx11_abi naming by zewenli98 · Pull Request #3361 · pytorch/TensorRT
Description
flip use_cxx11_abi naming
Type of change
Please delete options that are not relevant and/or add your own.
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- My code follows the style guidelines of this project (You can use the linters)
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas and hacks
- I have made corresponding changes to the documentation
- I have added tests to verify my fix or my feature
- New and existing unit tests pass locally with my changes
- I have added the relevant labels to my PR in so that relevant reviewers are notified
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be changes to .bazelrc
There needs to be changes to .bazelrc
@narendasan .bazelrc uses cxx11_abi as default. Only when specifying --config=python or --config=pre_cxx11_abi, it will compile using pre_cxx11_abi. Where do you think should be changed?
zewenli98
deleted the
flip_use_cxx11_abi_as_default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters