Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Summary by CodeRabbit

• Refactor
  • Reworked organization details to use a centralized context, improving reliability and maintainability without changing user workflows.
• New Features
  • Added an "Add Domain" section on the organization security page.
• Bug Fixes
  • Improved null-safety for organization data to prevent intermittent errors and ensure consistent titles and lists.
• Chores
  • Removed the previous preferences layout implementation.

Walkthrough

Replaces React Router Outlet/OutletContext usage with a children-based OrganizationDetails API and OrganizationContext access. Parent page now renders OrganizationDetails wrapping an Outlet; nested views obtain organization from OrganizationContext and null-safe optional chaining was added.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: export Organisations page as a component and consume it in apps/admin #1397: Similar migration away from OutletContext to OrganizationContext across organization-details code paths.
• fix: remove router reference #1403: Related changes to OrganizationDetails routing API and removal of router hooks, overlapping on component API and navigation integration.

• X
• Mastodon
• Reddit
• LinkedIn

web/sdk/admin/views/organizations/details/security/index.tsx (2)

13-13: Duplicate react import — merge into one.

Lines 13 and 24 both import from 'react'. These should be consolidated.

♻️ Proposed fix

-import { useContext } from 'react';
+import { useContext, useEffect } from 'react';
 import { OrganizationContext } from '../contexts/organization-context';
 import { BlockOrganizationSection } from './block-organization';
 import { DomainsList } from './domains-list';
 import { PageTitle } from '../../../../components/PageTitle';
 import { useQuery } from '@connectrpc/connect-query';
 import {
   FrontierServiceQueries,
   ListOrganizationDomainsRequestSchema
 } from '@raystack/proton/frontier';
 import { create } from '@bufbuild/protobuf';
-import { useEffect } from 'react';

Also applies to: 24-24

---

82-85: ?? [] fallback is redundant.

The select function already guarantees domains is always an array (data?.domains || []), so the ?? [] at the call site is unreachable.

♻️ Proposed fix

-          domains={domains ?? []}
+          domains={domains}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro