feat: add duration params in approver notification by utsav14nov · Pull Request #375 · raystack/guardian

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@utsav14nov

Copy link Copy Markdown

Contributor

No description provided.

@utsav14nov

Copy link Copy Markdown

Contributor Author

Will fix the test cases in next Mr.
Merging it for now. @bsushmith

@utsav14nov utsav14nov merged commit 931558d into main

Mar 13, 2023

@utsav14nov utsav14nov deleted the approval-duration-params branch

March 13, 2023 07:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsushmith bsushmith bsushmith approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@utsav14nov @bsushmith