chore: migrate typealias to interface by arpitBhalla · Pull Request #3374 · react-native-elements/react-native-elements
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 4.7k
Merged
arpitBhalla merged 5 commits intoreact-native-elements:nextfrom
Feb 26, 2022Merged
chore: migrate typealias to interface#3374
arpitBhalla merged 5 commits intoreact-native-elements:nextfrom
chore: migrate typealias to interface#3374
arpitBhalla merged 5 commits intoreact-native-elements:nextfrom
Conversation
Copy link
Member
Motivation
Type alias can't be merged, so revered back type to interface in Prop def
arpitBhalla added 2 commits
February 26, 2022 22:12
Copy link
Codecov Report
Merging #3374 (142dc52) into next (323e22c) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## next #3374 +/- ## ======================================= Coverage 78.88% 78.88% ======================================= Files 89 89 Lines 1733 1733 Branches 761 761 ======================================= Hits 1367 1367 Misses 361 361 Partials 5 5
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/base/src/AirbnbRating/AirbnbRating.tsx | 66.66% <ø> (ø) |
|
| packages/base/src/Avatar/Avatar.Accessory.tsx | 100.00% <ø> (ø) |
|
| packages/base/src/Avatar/Avatar.tsx | 97.22% <ø> (ø) |
|
| packages/base/src/Badge/Badge.tsx | 100.00% <ø> (ø) |
|
| packages/base/src/BottomSheet/BottomSheet.tsx | 100.00% <ø> (ø) |
|
| packages/base/src/ButtonGroup/ButtonGroup.tsx | 96.66% <ø> (ø) |
|
| packages/base/src/Card/Card.Divider.tsx | 100.00% <ø> (ø) |
|
| packages/base/src/Card/Card.FeaturedSubtitle.tsx | 100.00% <ø> (ø) |
|
| packages/base/src/Card/Card.FeaturedTitle.tsx | 100.00% <ø> (ø) |
|
| packages/base/src/Card/Card.Image.tsx | 100.00% <ø> (ø) |
|
| ... and 47 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 24b047c...142dc52. Read the comment docs.
arpitBhalla added 3 commits
February 26, 2022 22:43
arpitBhalla
merged commit
5b34d6c
into
react-native-elements:next
arpitBhalla
deleted the
interface
branch
github-actions bot pushed a commit that referenced this pull request
Feb 26, 2022github-actions bot pushed a commit that referenced this pull request
Feb 26, 2022github-actions bot pushed a commit that referenced this pull request
Feb 26, 2022
arpitBhalla
added
the
PR: New Feature 🎉
label
arpitBhalla added a commit that referenced this pull request
Mar 17, 2022arpitBhalla added a commit that referenced this pull request
Mar 19, 2022arpitBhalla added a commit that referenced this pull request
Mar 19, 2022This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment