fix: change InputProps shake props optional. by monk-lee · Pull Request #3426 · react-native-elements/react-native-elements
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 4.7k
Conversation
Motivation
Fixes # (issue)
Type of change
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
- Jest Unit Test
- Checked with
exampleapp
Checklist
- My code follows the style guidelines of this project
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas
- I have made corresponding changes to the documentation using
yarn docs-build-api - My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- Any dependent changes have been merged and published in downstream modules
Additional context
InputProps -> shake props should be optional.
Codecov Report
Merging #3426 (439fd9a) into next (65851b6) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## next #3426 +/- ## ======================================= Coverage 78.22% 78.22% ======================================= Files 87 87 Lines 1768 1768 Branches 780 780 ======================================= Hits 1383 1383 Misses 380 380 Partials 5 5
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/base/src/Input/Input.tsx | 65.78% <ø> (ø) |
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
arpitBhalla
changed the title
chore: change InputProps shake props optional.
fix: change InputProps shake props optional.
github-actions bot pushed a commit that referenced this pull request
Mar 29, 2022github-actions bot pushed a commit that referenced this pull request
Mar 29, 2022github-actions bot pushed a commit that referenced this pull request
Mar 29, 2022This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters