feat(Overlay): add KeyboardAvoidingView by kedar09 · Pull Request #3453 · react-native-elements/react-native-elements

Conversation

Fixes # (issue)
This change were made in response to this issue : #2748

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checked with example app

Checklist

My code follows the style guidelines of this project
My changes generate no new warnings

Additional context

In Overlay, KeyboardAvoidingView is not working in iOS.

… into overlay_ios_KeyboardAvoidingView

Codecov Report

Merging #3453 (cafad51) into next (39f56fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3453   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files          87       87           
  Lines        1821     1821           
  Branches      812      812           
=======================================
  Hits         1446     1446           
  Misses        370      370           
  Partials        5        5

Impacted Files	Coverage Δ
packages/base/src/Overlay/Overlay.tsx	`100.00% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kedar09 did you tested it for iOS too?

yes I have tested on iOS and android

		testID="RNE__Overlay__Container"
		style={styles.container}
		pointerEvents="box-none"
		behavior={Platform.OS === 'ios' ? 'padding' : 'height'}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can move outside (ideally in helpers folder)

tsukudabuddha added a commit to tsukudabuddha/CurrencyExchange that referenced this pull request

Jun 6, 2022

arpitBhalla changed the title ~~fix(Overlay) - added KeyboardAvoidingView~~ featOverlay): add KeyboardAvoidingView

Nov 3, 2022

arpitBhalla changed the title ~~featOverlay): add KeyboardAvoidingView~~ feat(Overlay): add KeyboardAvoidingView