fix(withTheme): add `spacing` to non-ThemeProvider components by arpitBhalla · Pull Request #3525 · react-native-elements/react-native-elements
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 4.7k
Merged
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
May 16, 2022Merged
Conversation
Copy link
Member
arpitBhalla
commented
May 16, 2022
arpitBhalla
commented
Motivation
Fixes # (issue)
Type of change
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
- Jest Unit Test
- Checked with
exampleapp
Checklist
- My code follows the style guidelines of this project
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas
- I have made corresponding changes to the documentation using
yarn docs-build-api - My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- Any dependent changes have been merged and published in downstream modules
Additional context
arpitBhalla
added
the
PR: Bug Fix 🐛
label
1 task
Copy link
codecov
bot
commented
May 16, 2022
codecov bot commented
May 16, 2022Codecov Report
Merging #3525 (81f8469) into next (eaeacb3) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## next #3525 +/- ## ======================================= Coverage 79.18% 79.18% ======================================= Files 87 87 Lines 1806 1806 Branches 810 810 ======================================= Hits 1430 1430 Misses 369 369 Partials 7 7
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/themed/src/config/withTheme.tsx | 75.67% <ø> (ø) |
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
arpitBhalla
merged commit
2ec13f9
into
react-native-elements:next
github-actions bot pushed a commit that referenced this pull request
May 16, 2022github-actions bot pushed a commit that referenced this pull request
May 16, 2022
arpitBhalla
deleted the
button-non-themeprovider
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment