fix: property 'children' does not exist in React 18 by arpitBhalla · Pull Request #3663 · react-native-elements/react-native-elements

@arpitBhalla

Motivation

Fixes #3628

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla

@arpitBhalla arpitBhalla changed the title fix fix: property 'children' does not exist on type 'IntrinsicAttributes & AvatarProps in React 18

Oct 25, 2022

@arpitBhalla arpitBhalla changed the title fix: property 'children' does not exist on type 'IntrinsicAttributes & AvatarProps in React 18 fix: property 'children' does not exist in React 18

Oct 25, 2022

@codecov

Codecov Report

Merging #3663 (bb9f10c) into next (67eb98b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             next    #3663   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files          87       87           
  Lines        1821     1821           
  Branches      812      812           
=======================================
  Hits         1446     1446           
  Misses        370      370           
  Partials        5        5           
Impacted Files Coverage Δ
packages/themed/src/config/withTheme.tsx 86.48% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla linked an issue

Oct 25, 2022

that may be closed by this pull request

1 task