fix(Divider): borderBottomWidth error when the width is a percentage by phankietit · Pull Request #3804 · react-native-elements/react-native-elements

@phankietit

  • Error when the width is a percentage. Ex: 90%

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

- Error when the width is a percentage. Ex: 90%

@phankietit

@netlify

@phankietit phankietit changed the title fix: divider borderBottomWidth error when the width is a percentage fix(Divider): borderBottomWidth error when the width is a percentage

Jun 9, 2023

@codecov

Codecov Report

Merging #3804 (e76337d) into next (3c6eac2) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e76337d differs from pull request most recent head 341134b. Consider uploading reports for the commit 341134b to get more accurate results

@@           Coverage Diff           @@
##             next    #3804   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files          87       87           
  Lines        1822     1822           
  Branches      804      804           
=======================================
  Hits         1455     1455           
  Misses        362      362           
  Partials        5        5           
Impacted Files Coverage Δ
packages/base/src/Divider/Divider.tsx 92.30% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more