feat: generate code that uses `Array.Empty` where possible by TimothyMakkison · Pull Request #1599

feat: generate code that uses `Array.Empty` where possible by TimothyMakkison · Pull Request #1599 · reactiveui/refit

Conversation

Use Array.Empty over allocating an empty array where possible. Done for ______arguments and parameterTypes..

See #1598

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for the solid PR. @clairernovotny, can you think of anything this might break?

Can't think of any issues this would cause. Thanks!

Sorry about that, should be fixed now 🤞

Any chance you'd be open to running a formatter on this repository? A lot of lines appear to have random 4-8 sections of whitespace.

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af399f0) 85.45% compared to head (9f8883d) 85.45%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1599   +/-   ##
=======================================
  Coverage   85.45%   85.45%           
=======================================
  Files          33       33           
  Lines        1685     1685           
  Branches      295      295           
=======================================
  Hits         1440     1440           
  Misses        166      166           
  Partials       79       79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions bot locked as resolved and limited conversation to collaborators

Dec 2, 2023