feat: add leading underscores to `typeParameter` name by TimothyMakkison · Pull Request #1641 · reactiveui/refit

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@TimothyMakkison

Copy link Copy Markdown

Contributor

@TimothyMakkison TimothyMakkison commented

Jan 16, 2024

edited

Loading

Added leading underscores to typeParameter to be inline with the other variables (______arguments and ______func).

Should prevent a scenario where the name is already used in the interface.

@TimothyMakkison TimothyMakkison changed the title feat: add leading underscores to typeParameter name feat: add leading underscores to typeParameter name

Jan 16, 2024

@codecov

Copy link Copy Markdown

codecov bot commented

Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83cf3f8) 87.73% compared to head (71ea4fd) 87.73%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1641   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          33       33           
  Lines        2348     2348           
  Branches      294      294           
=======================================
  Hits         2060     2060           
  Misses        208      208           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glennawatson glennawatson merged commit b7c22ca into reactiveui:main

Feb 17, 2024

@github-actions

Copy link Copy Markdown

github-actions bot commented

Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Mar 3, 2024

@TimothyMakkison TimothyMakkison deleted the rename_type_param branch

March 3, 2024 00:52

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@glennawatson glennawatson glennawatson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @glennawatson