feat: add leading underscores to `typeParameter` name by TimothyMakkison · Pull Request #1641 · reactiveui/refit
Navigation Menu
{{ message }}
reactiveui / refit Public
- Notifications You must be signed in to change notification settings
- Fork 783
Merged
glennawatson merged 1 commit intoreactiveui:mainfrom
Feb 17, 2024Merged
feat: add leading underscores to typeParameter name#1641
glennawatson merged 1 commit intoreactiveui:mainfrom
feat: add leading underscores to typeParameter name#1641
glennawatson merged 1 commit intoreactiveui:mainfrom
Conversation
Copy link Copy Markdown
Contributor
Added leading underscores to typeParameter to be inline with the other variables (______arguments and ______func).
Should prevent a scenario where the name is already used in the interface.
TimothyMakkison
changed the title
feat: add leading underscores to typeParameter name
feat: add leading underscores to typeParameter name
Copy link Copy Markdown
codecov
bot
commented
Jan 16, 2024
codecov bot commented
Jan 16, 2024Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
83cf3f8) 87.73% compared to head (71ea4fd) 87.73%.
Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1641 +/- ## ======================================= Coverage 87.73% 87.73% ======================================= Files 33 33 Lines 2348 2348 Branches 294 294 ======================================= Hits 2060 2060 Misses 208 208 Partials 80 80
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
glennawatson approved these changes Feb 17, 2024
glennawatson
merged commit
b7c22ca
into
reactiveui:main
Copy link Copy Markdown
github-actions
bot
commented
Mar 3, 2024
github-actions bot commented
Mar 3, 2024This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
github-actions
bot
locked as resolved and limited conversation to collaborators
TimothyMakkison
deleted the
rename_type_param
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.