Rewrote CachedRequestBuilder to use a custom MethodTableKey value as a dictionary key instead of a concatenated string. Resulted in some modest memory savings and reduced object usage.

• Added unit tests to ensure that the dictionary key works correctly.
• On lines 48 & 49 of CachedRequestBuilderImplementation I copy the arrays to create the dictionary key, this is to prevent the arrays being changed, breaking the dictionary. This can be removed if Refit assumes that the input arrays are not accessible to the user.
• Implemented IEquatable<MethodTableKey>, implementing my own GetHashCode method. I could have used the recommended HashCode object but it is not available in .NET Framework. I could copy the implementation over and use it if you want.

Original

With changes

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (6ebeda5) to head (70d836a).
Report is 44 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1716      +/-   ##
==========================================
- Coverage   87.73%   84.57%   -3.16%     
==========================================
  Files          33       35       +2     
  Lines        2348     2503     +155     
  Branches      294      325      +31     
==========================================
+ Hits         2060     2117      +57     
- Misses        208      304      +96     
- Partials       80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Was this added? I don't see it in the commits for main?

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.