Uses ValueStringBuilder to generate query parameters for the uri and prepend a question mark.

Update: turns out UriBuilder has been changed between .NET Framework and Core. Core checks for leading ? symbols whereas Framework always adds one. I've added a preprocessor directive to resovle this issue.

Original

Changes

@TimothyMakkison there's a merge conflict, is it possible for you to solve this? I am in Dubai at the moment and the connection is very poor, once the conflict is solved, I will try to review this PR.

Codecov Report

Attention: Patch coverage is 32.84672% with 92 lines in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (6ebeda5) to head (5428291).
Report is 41 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1719      +/-   ##
==========================================
- Coverage   87.73%   84.69%   -3.04%     
==========================================
  Files          33       35       +2     
  Lines        2348     2483     +135     
  Branches      294      317      +23     
==========================================
+ Hits         2060     2103      +43     
- Misses        208      300      +92     
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyMakkison there's a merge conflict, is it possible for you to solve this? I am in Dubai at the moment and the connection is very poor, once the conflict is solved

Should be up to date now and I've made a couple of readability improvements.

I will try to review this PR.

I'm in no rush to have this merged, please don't take time out of your holiday for this 😄

I see that #1389 is closed, as a maintainer do you think my proposal would be accepted? I'm pretty confident I can prevent any breaking changes while drastically improving startup times, but I'm not sure if the core team is interested. Otherwise I can continue improving the current library.

I'm working here in Dubai unfortunately, but just until the end of this month, I still get to benefit from the good weather 🙂, I will make time over the weekend to go through a few things. I have made a release, hopefully nothing bad happened with it, I have seen one element that needs updating to resolve, but a fairly simple temporary fix for the user.

I need to create a good service and client combination to use as a live test, as not everything is tested and some things seem untestable due to the nature of the code.

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.