Home Original page

feat: defer header dictionary creation by TimothyMakkison · Pull Request #1745 · reactiveui/refit

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@TimothyMakkison

Defer header dictionary creation, saves 72 bytes if a header is not set.

Original

Method Mean Error StdDev Gen0 Gen1 Allocated
ConstantRouteAsync 2.032 us 0.0223 us 0.0209 us 0.6905 - 6.36 KB
DynamicRouteAsync 2.626 us 0.0186 us 0.0165 us 0.7248 0.0038 6.68 KB
ComplexDynamicRouteAsync 3.825 us 0.0197 us 0.0175 us 0.7935 0.0076 7.31 KB
ObjectRequestAsync 4.470 us 0.0250 us 0.0234 us 0.8774 - 8.13 KB
ComplexRequestAsync 12.379 us 0.0479 us 0.0448 us 1.5411 0.0153 14.19 KB

Header changes

Method Mean Error StdDev Median Gen0 Gen1 Allocated
ConstantRouteAsync 3.560 us 0.3364 us 0.9919 us 3.072 us 0.6790 0.0076 6.28 KB
DynamicRouteAsync 2.939 us 0.0524 us 0.0490 us 2.953 us 0.7172 - 6.6 KB
ComplexDynamicRouteAsync 4.288 us 0.0851 us 0.1796 us 4.241 us 0.7858 0.0076 7.24 KB
ObjectRequestAsync 4.880 us 0.0921 us 0.0905 us 4.848 us 0.8698 - 8.05 KB
ComplexRequestAsync 13.322 us 0.2608 us 0.3482 us 13.142 us 1.5411 0.0153 14.19 KB

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (6ebeda5) to head (201b2cd).
Report is 53 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
- Coverage   87.73%   83.91%   -3.83%     
==========================================
  Files          33       36       +3     
  Lines        2348     2443      +95     
  Branches      294      343      +49     
==========================================
- Hits         2060     2050      -10     
- Misses        208      309     +101     
- Partials       80       84       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ChrisPulman

@github-actions

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Jul 15, 2024

2 participants

@TimothyMakkison @ChrisPulman