feat: fix form url encoded strings #1593 by TimothyMakkison · Pull Request #1752 · reactiveui/refit
Navigation Menu
{{ message }}
reactiveui / refit Public
- Notifications You must be signed in to change notification settings
- Fork 783
Merged
ChrisPulman merged 1 commit intoreactiveui:mainfrom
Jul 1, 2024Merged
feat: fix form url encoded strings #1593#1752
ChrisPulman merged 1 commit intoreactiveui:mainfrom
feat: fix form url encoded strings #1593#1752
ChrisPulman merged 1 commit intoreactiveui:mainfrom
Conversation
Copy link Copy Markdown
Contributor
Add check for strings to form url encoded requests. This way strings aren't serialized as collections. Added relevant test.
Fixes #1593
Copy link Copy Markdown
codecov
bot
commented
Jul 1, 2024
codecov bot commented
Jul 1, 2024Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 83.66%. Comparing base (
6ebeda5) to head (e9c8380).
Report is 57 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1752 +/- ## ========================================== - Coverage 87.73% 83.66% -4.07% ========================================== Files 33 36 +3 Lines 2348 2443 +95 Branches 294 343 +49 ========================================== - Hits 2060 2044 -16 - Misses 208 316 +108 - Partials 80 83 +3
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
ChrisPulman approved these changes Jul 1, 2024
ChrisPulman
merged commit
a8fcd12
into
reactiveui:main
Copy link Copy Markdown
github-actions
bot
commented
Jul 16, 2024
github-actions bot commented
Jul 16, 2024This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
github-actions
bot
locked as resolved and limited conversation to collaborators
TimothyMakkison
deleted the
fix_url_body_string
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.