feat: fix form url encoded strings #1593 by TimothyMakkison · Pull Request #1752 · reactiveui/refit

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@TimothyMakkison

Copy link Copy Markdown

Contributor

@TimothyMakkison TimothyMakkison commented

Jul 1, 2024

edited

Loading

Add check for strings to form url encoded requests. This way strings aren't serialized as collections. Added relevant test.

Fixes #1593

@codecov

Copy link Copy Markdown

codecov bot commented

Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (6ebeda5) to head (e9c8380).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1752      +/-   ##
==========================================
- Coverage   87.73%   83.66%   -4.07%     
==========================================
  Files          33       36       +3     
  Lines        2348     2443      +95     
  Branches      294      343      +49     
==========================================
- Hits         2060     2044      -16     
- Misses        208      316     +108     
- Partials       80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit a8fcd12 into reactiveui:main

Jul 1, 2024

@github-actions

Copy link Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Jul 16, 2024

@TimothyMakkison TimothyMakkison deleted the fix_url_body_string branch

July 16, 2024 08:16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChrisPulman ChrisPulman ChrisPulman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: CollectionFormat.Csv causes strings to be serialized as comma separated chars

2 participants

@TimothyMakkison @ChrisPulman