feat: added generator tests by TimothyMakkison · Pull Request #1765 · reactiveui/refit
Navigation Menu
{{ message }}
reactiveui / refit Public
- Notifications You must be signed in to change notification settings
- Fork 783
Merged
ChrisPulman merged 1 commit intoreactiveui:mainfrom
Jul 25, 2024Merged
feat: added generator tests#1765
ChrisPulman merged 1 commit intoreactiveui:mainfrom
feat: added generator tests#1765
ChrisPulman merged 1 commit intoreactiveui:mainfrom
Conversation
Copy link Copy Markdown
Contributor
TimothyMakkison
commented
Jul 25, 2024
TimothyMakkison
commented
Redo of #1753, this time focusing on individual cases.
- Added some basic tests.
- I intend to keep
InterfaceStubGeneratorin the main tests to target the latest version of .NET framework if possible. I'm trying not to use unsafe code in a rewrite, but if I do .NET Framework will have to be handled uniquely. - Using this in my source generator rewrite, I'm trying to split it into smaller PRs so I don't dump a massive change on you.
- Got a pr with
Verify.SourceGeneratorto add a way to ignore certain files. I'd like to use it on the duplicatePreserveAttribute.csfiles.
TimothyMakkison
force-pushed
the
generator_test
branch
from
b7cc243 to
71d9653
Compare
TimothyMakkison
marked this pull request as ready for review
Copy link Copy Markdown
codecov
bot
commented
Jul 25, 2024
codecov bot commented
Jul 25, 2024Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 83.58%. Comparing base (
6ebeda5) to head (71d9653).
Report is 63 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1765 +/- ## ========================================== - Coverage 87.73% 83.58% -4.15% ========================================== Files 33 36 +3 Lines 2348 2431 +83 Branches 294 343 +49 ========================================== - Hits 2060 2032 -28 - Misses 208 316 +108 - Partials 80 83 +3
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
ChrisPulman approved these changes Jul 25, 2024
ChrisPulman
closed this
ChrisPulman
reopened this
ChrisPulman
merged commit
923b961
into
reactiveui:main
Copy link Copy Markdown
github-actions
bot
commented
Aug 9, 2024
github-actions bot commented
Aug 9, 2024This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
github-actions
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.