feat: added generator tests by TimothyMakkison · Pull Request #1765 · reactiveui/refit

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@TimothyMakkison

Copy link Copy Markdown

Contributor

Redo of #1753, this time focusing on individual cases.

  • Added some basic tests.
  • I intend to keep InterfaceStubGenerator in the main tests to target the latest version of .NET framework if possible. I'm trying not to use unsafe code in a rewrite, but if I do .NET Framework will have to be handled uniquely.
  • Using this in my source generator rewrite, I'm trying to split it into smaller PRs so I don't dump a massive change on you.
  • Got a pr with Verify.SourceGenerator to add a way to ignore certain files. I'd like to use it on the duplicate PreserveAttribute.cs files.

@TimothyMakkison TimothyMakkison marked this pull request as ready for review

July 25, 2024 21:43

@codecov

Copy link Copy Markdown

codecov bot commented

Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (6ebeda5) to head (71d9653).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
- Coverage   87.73%   83.58%   -4.15%     
==========================================
  Files          33       36       +3     
  Lines        2348     2431      +83     
  Branches      294      343      +49     
==========================================
- Hits         2060     2032      -28     
- Misses        208      316     +108     
- Partials       80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman reopened this

Jul 25, 2024

@ChrisPulman ChrisPulman merged commit 923b961 into reactiveui:main

Jul 25, 2024

@github-actions

Copy link Copy Markdown

github-actions bot commented

Aug 9, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Aug 9, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChrisPulman ChrisPulman ChrisPulman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @ChrisPulman