feat: added source generator benchmarks by TimothyMakkison · Pull Request #1798 · reactiveui/refit
Navigation Menu
{{ message }}
reactiveui / refit Public
- Notifications You must be signed in to change notification settings
- Fork 783
Merged
ChrisPulman merged 3 commits intoreactiveui:mainfrom
Sep 1, 2024Merged
feat: added source generator benchmarks#1798
ChrisPulman merged 3 commits intoreactiveui:mainfrom
feat: added source generator benchmarks#1798
ChrisPulman merged 3 commits intoreactiveui:mainfrom
Conversation
Copy link Copy Markdown
Contributor
Added benchmarks for source generation.
Assuming these benchmarks are valid, the results show a very small benefit from caching.
Benchmarks
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
|---|---|---|---|---|---|---|
| Compile | 225.9 us | 3.34 us | 2.96 us | 13.1836 | 2.9297 | 124.09 KB |
| Cached | 196.7 us | 3.37 us | 2.99 us | 13.1836 | 2.9297 | 122.19 KB |
| Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated |
|---|---|---|---|---|---|---|---|
| Compile | 225.0 us | 4.42 us | 9.22 us | 221.2 us | 13.1836 | 2.9297 | 124.09 KB |
| Cached | 197.6 us | 2.77 us | 2.59 us | 197.0 us | 13.1836 | 2.9297 | 122.18 KB |
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
|---|---|---|---|---|---|---|
| Compile | 228.9 us | 4.55 us | 6.67 us | 13.1836 | 2.9297 | 124.09 KB |
| Cached | 197.5 us | 2.14 us | 2.00 us | 13.1836 | 2.9297 | 122.18 KB |
TimothyMakkison
marked this pull request as draft
Copy link Copy Markdown
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 83.66%. Comparing base (
6ebeda5) to head (d6a4e2a).
Report is 79 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1798 +/- ## ========================================== - Coverage 87.73% 83.66% -4.08% ========================================== Files 33 36 +3 Lines 2348 2442 +94 Branches 294 345 +51 ========================================== - Hits 2060 2043 -17 - Misses 208 316 +108 - Partials 80 83 +3
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
TimothyMakkison
force-pushed
the
gen_benchmark
branch
from
f11f90a to
e8e841b
Compare
TimothyMakkison
marked this pull request as ready for review
TimothyMakkison
mentioned this pull request
TimothyMakkison
force-pushed
the
gen_benchmark
branch
from
e8e841b to
fe9ca75
Compare
Copy link Copy Markdown
Contributor Author
TimothyMakkison
commented
Aug 31, 2024
TimothyMakkison commented
Aug 31, 2024Do you want me to rebase this?
ChrisPulman approved these changes Sep 1, 2024
ChrisPulman
enabled auto-merge (squash)
ChrisPulman
merged commit
f77f0f3
into
reactiveui:main
Copy link Copy Markdown
github-actions
bot
commented
Sep 16, 2024
github-actions bot commented
Sep 16, 2024This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
github-actions
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants