chore: ignore repeat files and add test by TimothyMakkison · Pull Request #1804 · reactiveui/refit

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@TimothyMakkison

Copy link Copy Markdown

Contributor

Used the new IgnoreGeneratedResult to ignore PreserveAttribute and Generated files from the snapshot tests.

  • Added ShouldEmitAllFiles snapshot test to verify that the generated files are still created.

@codecov

Copy link Copy Markdown

codecov bot commented

Sep 3, 2024

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (6ebeda5) to head (c08e83c).
Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1804      +/-   ##
==========================================
- Coverage   87.73%   83.66%   -4.08%     
==========================================
  Files          33       36       +3     
  Lines        2348     2442      +94     
  Branches      294      345      +51     
==========================================
- Hits         2060     2043      -17     
- Misses        208      316     +108     
- Partials       80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit 7824135 into reactiveui:main

Sep 6, 2024

@TimothyMakkison TimothyMakkison deleted the ignore_files branch

September 8, 2024 14:31

@github-actions

Copy link Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Sep 24, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChrisPulman ChrisPulman ChrisPulman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @ChrisPulman